On Wed, 9 Nov 2011, DJ Delorie wrote:
> Index: MAINTAINERS
> ===================================================================
> rs6000 port Geoff Keating geo...@geoffk.org
> rs6000 port David Edelsohn dje....@gmail.com
> rs6000 vector extns Aldy Hernandez al...@redhat.com
> +rl78 port DJ Delorie d...@redhat.com
"rl" > "rs", mind sorting this in?
> Index: gcc/doc/extend.texi
> ===================================================================
> -the SPU and M32C targets support other address spaces. On the SPU target,
> for
> +the SPU, M32C, and RL78 targets support other address spaces. On the SPU
> target, for
Mind the long line.
> +On the RL78 target, variables qualified with @code{__far} are accessed
> +with 32-bit pointers (20 bit addresses) rather than the default 16-bit
"20-bit"
> +addresses. Non-far variables are assumed to appear in the topmost 64K
> +of the address space.
I suggest to explicitly refer to kB or kb (byte or bit) perhaps?
> Index: gcc/doc/invoke.texi
> ===================================================================
> * PowerPC Options::
> * RS/6000 and PowerPC Options::
> +* RL78 Options::
> * RX Options::
> * S/390 and zSeries Options::
Same note on sorting as above. :-)
> +@node RL78 Options
> +@subsection RL78 Options
> +@cindex RL78 Options
Ditto.
> +@item -msim
> +@opindex msim
> +Link in additional target libraries to support operation within a
> +simulator.
"Link", versus...
> +@item -mmul=none
> +@itemx -mmul=g13
> +@itemx -mmul=rl78
> +@opindex mmul
> +Selects the type of hardware multiplication support desired.
..."Selects" feels a bit inconsistent, though I can also see the
argument where "link" is what the program does, whereas "select"
is what the user does.
> Index: gcc/doc/md.texi
> ===================================================================
> +@item Int3
> +An integer constant in the range 1 @dots{} 7.
> +@item Int8
> +An integer constant in the range 0 @dots{} 255.
Really 1..7, not 0..7? That's unexpected and a bit inconsistent
with Int8. Not sure I have a good alternative to offer, perhaps
someone else has a more creative idea?
(Reading through this, some very fond memories of the Z80 come up
in my memories. :-)
> +<dt><span>Renesas RL78 processor support</span>
> + <span class="date">[2011-11-09]</span></dt>
> +<dd>A port for the Renesas RL78 family of processors has been contributed by
> +Red Hat.</dd>
Don't you want to mention your name there? I would find that
appropriate.
Do you consider the links from install.texi important? Keep them if
you do, in general we try to minimize those (and keep them in
readings.html where you have added the same links).
All .texi and .html changes are okay, modulo the notes above.
Gerald
