On Mon, Jun 24, 2019 at 05:52:36PM -0500, Bill Seurer wrote:
> [PATCH, rs6000] Split up rs6000.c.
>
> The source file rs6000.c has grown to unreasonable size
1.2MB, 40k lines. With various includes of tables.
> and is being
> split up into several smaller source files. This should improve
> compilation speed for building gcc.
>
> This is the first of several patches to do this and moves most of the
> prologue/epilogue code to a new source file.
Thanks for doing this.
> rs6000_emit_probe_stack_range_stack_clash,
(trailing space here)
> interesting_frame_related_regno,
(and here)
> emit_vrsave_prologue, emit_split_stack_prologue,
(and here).
> rs6000_split_stack_space_check, rs6000_save_toc_in_prologue_p): Moved
> to rs6000-logue.c.
What a nasty name. I like it :-)
> rs6000_emit_probe_stack_range_stack_clash,
(trailing space)
> interesting_frame_related_regno,
(yup)
> emit_vrsave_prologue, emit_split_stack_prologue,
(and here)
> * config/rs6000/rs6000.h (machine_function): Moved to here from
(last one)
> --- gcc/config/rs6000/rs6000-internal.h (nonexistent)
> +++ gcc/config/rs6000/rs6000-internal.h (working copy)
> @@ -0,0 +1,113 @@
> +/* Internal to rs6000 type and variable declarations and definitons
Trailing space; typo ("definitions").
Definitions do not really belong in .h files, but I didn't see any anyway?
(Except the one static inline, which is more like a macro really). So
maybe just say declarations?
> -static gty(()) section *toc_section;
>
> +extern gty(()) section *toc_section;
> +section *toc_section = 0;
You probably shouldn't call it extern if it isn't ;-) (Or is that needed
for the gty magic?)
Okay for trunk. Thanks!
Segher
