On 6/25/19 4:43 PM, Jeff Law wrote:
> On 6/25/19 2:22 PM, acsaw...@linux.ibm.com wrote:
>> From: Aaron Sawdey <acsaw...@linux.ibm.com>
>>
>> * builtins.c (get_memory_rtx): Fix comment.
>> * optabs.def (movmem_optab): Change to cpymem_optab.
>> * expr.c (emit_block_move_via_cpymem): Change movmem to cpymem.
>> (emit_block_move_hints): Change movmem to cpymem.
>> * defaults.h: Change movmem to cpymem.
>> * targhooks.c (get_move_ratio): Change movmem to cpymem.
>> (default_use_by_pieces_infrastructure_p): Ditto.
> So I think you're missing an update to the RTL/MD documentation. This
> is also likely to cause problems for any out-of-tree ports, so it's
> probably worth a mention in the gcc-10 changes, which will need to be
> created (in CVS no less, ugh).
>
> I think the stuff posted to-date is fine, but it shouldn't go in without
> the corresponding docs and gcc-10 changes updates.
Here is the corresponding documentation change for gcc-10/changes.html.
OK for trunk?
Thanks,
Aaron
Index: changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-10/changes.html,v
retrieving revision 1.4
diff -r1.4 changes.html
139c139,149
< <!-- <h2>Other significant improvements</h2> -->
---
> <h2>Other significant improvements</h2>
> <ul>
> <li>
> To allow inline expansion of both <code>memcpy</code>
> and <code>memmove</code>, the existing <code>movmem</code> instruction
> patterns used for non-overlapping memory copies have been renamed to
> <code>cpymem</code>. The <code>movmem</code> name is now used
> for overlapping memory moves, consistent with the
> library functions <code>memcpy</code> and <code>memmove</code>.
> </li>
> </ul>
--
Aaron Sawdey, Ph.D. acsaw...@linux.vnet.ibm.com
050-2/C113 (507) 253-7520 home: 507/263-0782
IBM Linux Technology Center - PPC Toolchain
