> > > On 27 Jun 2019, at 19:21, Jan Hubicka <hubi...@ucw.cz> wrote: > > > >> > >> It's useful on targets without COMDAT support. Are there any such > >> that we care about at this point? > >> > >> If the problem is the combination with LTO, why not just prohibit that? > > > > The problem is that at the collect2 time we want to decide whether to > > hold stderr/stdout of the linker. The issue is that we do not know yet > > if we are going to LTO (because that is decided by linker plugin) or > > whether we do repo files (because we look for those only after linker > > failure). > > you could pre-scan for LTO, as is done for the collect2+non-plugin linker. > (similar to the comment below, that would take some time, but probably > small c.f the actual link).
the collect2+non-plugin does not handle static archives so it would need more work while I think we should kill that code (and make darwin to use lld) Honza > Iain > > > We can look for repo files first but that could take some time > > especially for large programs (probably not too bad compared to actual > > linking later) or we may require -frepo to be passed to collect2. > > > > Honza > >> > >> Jason >