On 7/1/19 7:16 AM, Andrew Stubbs wrote:
On 28/06/2019 17:21, Jason Merrill wrote:+ inform ((decl ? DECL_SOURCE_LOCATION (decl) : UNKNOWN_LOCATION), + "incomplete types are not mappable");It's better to use input_location as a fallback; essentially no diagnostics should use UNKNOWN_LOCATION. And let's print the type with %qT.+ if (notes) + result = false; + else + return false;Returning early when !notes doesn't seem worth the extra lines of code.How is this version?
OK, thanks. Jason
