On Thu, Jul 18, 2019 at 02:20:43PM -0400, Michael Meissner wrote: > On Tue, Jul 16, 2019 at 03:58:18PM -0500, Segher Boessenkool wrote: > > > I did not move the initialization of the TOC_alias_set > > > elsewhere, because in order to call TOC_alias_set, the code has already > > > called > > > force_const_mem, create_TOC_reference, and gen_const_mem, so I didn't see > > > the > > > point of adding a micro-optimization for this. > > > > It gets rid of a call, but also of the conditional, and that makes this > > eminently inlinable. You could remove the getter function completely > > even, access the variable directly. > > > > But, sure, that's existing code only now. > > We can fix this later.
Yup :-) > I did rename the TARGET_NO_TOC macro to TARGET_NO_TOC_OR_PCREL which hopefully > makes it more obvious when it should be true. It does, thanks! Segher
