On Thu, 18 Jul 2019 16:55:59 -0500
Segher Boessenkool <seg...@kernel.crashing.org> wrote:
> Hi!
Hi Segher,
>
> On Thu, Jul 18, 2019 at 08:45:38PM +0100, Jozef Lawrynowicz wrote:
> > PR target/70320
> > * doc/tm.texi.in: Document new macro CASE_INSENSITIVE_REGISTER_NAMES.
> > * doc/tm.texi: Likewise.
>
> "Regenerate." -- or did you edit this file by hand? Don't, or don't tell
> us anyway ;-)
I did indeed regenerate it, that's just a mistake in the ChangeLog.
>
> > strcmp for comparisons of asmspec with a register name if
>
> (Trailing space here, and elsewhere).
Ah, I was given false confidence by contrib/check_GNU_style.sh, I guess that
only checks +/- lines.
>
> > +/* { dg-do compile } */
> > +/* { dg-options "-ffixed-r6 -ffixed-R7" } */
> > +/* { dg-final { scan-assembler "PUSH.*R4" } } */
> > +/* { dg-final { scan-assembler "PUSH.*R5" } } */
>
> scan-assembler does multi-line matching by default, so that .* probably
> matches things you do not want it to match. You can do things like
>
> /* { dg-final { scan-assembler "(?n)PUSH.*R5" } } */
>
> to make sure this is on one line at least. See man re_syntax.
Right, thanks for pointing that out, the test was in fact matching cases it
shouldn't have been due to the multi-line matching.
Thanks for the review,
Jozef
>
> Rest looks fine, but I'm not an RTL maintainer.
>
>
> Segher
