On Mon, Aug 05, 2019 at 01:29:26PM -0500, Segher Boessenkool wrote: > On Mon, Aug 05, 2019 at 02:14:50PM -0400, Arvind Sankar wrote: > > On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: > > > > -/* Predicate yielding true iff X is an rtx for a double-int. */ > > > > +/* Predicate yielding true iff X is an rtx for a floating point > > > > constant. */ > > > > #define CONST_DOUBLE_AS_FLOAT_P(X) \ > > > > (GET_CODE (X) == CONST_DOUBLE && GET_MODE (X) != VOIDmode) > > > > > > Is const_double really only used for floating point these days? > > > Are you asking if the CONST_DOUBLE_AS_INT_P possibility is dead code > > now? That's beyond my current level of understanding of the code, > > hopefully someone else will chime in. > > I am asking if the change to this comment is correct. >
Ah. The comment was originally copy-pasted from the one for CONST_DOUBLE_AS_INT_P, and it seemed clearly wrong. The comment for CONST_DOUBLE_P (which only checks the code and not the machine mode) says it can either be a double-int or a floating point constant.