On Wed, Nov 23, 2011 at 08:10:00AM -0200, Alexandre Oliva wrote:
> - compiling stage2 target libs and stage3 host patched sources (with
> both unpatched and patched stage2 compiler) produced cc1plus with 10%
> fewer entry value expressions (a welcome surprise!), 1% fewer call site
> value expressions, an increase of 0.1% in the total number of variables
> with location lists and less than 0.5% decrease in variables with full
> coverage.
The numbers I got with your patch (RTL checking) are below, seems
the cumulative numbers other than 100% are all bigger with patched stage2,
which means unfortunately debug info quality degradation. Have you
analysed at least on some shorter testcases why does that happen?
Otherwise the patch looks good to me.
x86_64 patched stage3 compiled by vanilla stage2
cov% samples cumul
0.0 230172/32% 230172/32%
0..10 12267/1% 242439/34%
11..20 10548/1% 252987/35%
21..30 17018/2% 270005/37%
31..40 16374/2% 286379/40%
41..50 17533/2% 303912/42%
51..60 13051/1% 316963/44%
61..70 13946/1% 330909/46%
71..80 19627/2% 350536/49%
81..90 28877/4% 379413/53%
91..99 85086/11% 464499/65%
100 246568/34% 711067/100%
x86_64 patched stage3 compiled by patched stage2
cov% samples cumul
0.0 230182/32% 230182/32%
0..10 12319/1% 242501/34%
11..20 10765/1% 253266/35%
21..30 17390/2% 270656/38%
31..40 16745/2% 287401/40%
41..50 17821/2% 305222/42%
51..60 13306/1% 318528/44%
61..70 14104/1% 332632/46%
71..80 19795/2% 352427/49%
81..90 29030/4% 381457/53%
91..99 85171/11% 466628/65%
100 244439/34% 711067/100%
i686 patched stage3 compiled by vanilla stage2
cov% samples cumul
0.0 225909/32% 225909/32%
0..10 12420/1% 238329/34%
11..20 10693/1% 249022/35%
21..30 17102/2% 266124/38%
31..40 13529/1% 279653/40%
41..50 17232/2% 296885/42%
51..60 12568/1% 309453/44%
61..70 14769/2% 324222/46%
71..80 14937/2% 339159/48%
81..90 23868/3% 363027/52%
91..99 86306/12% 449333/64%
100 245327/35% 694660/100%
i686 patched stage3 compiled by patched stage2
cov% samples cumul
0.0 225917/32% 225917/32%
0..10 12471/1% 238388/34%
11..20 10848/1% 249236/35%
21..30 17292/2% 266528/38%
31..40 13716/1% 280244/40%
41..50 17324/2% 297568/42%
51..60 12673/1% 310241/44%
61..70 14950/2% 325191/46%
71..80 15085/2% 340276/48%
81..90 24019/3% 364295/52%
91..99 86228/12% 450523/64%
100 244137/35% 694660/100%
Jakub
