On Mon, 9 Sep 2019, Martin Liška wrote:
I'm sending slightly updated version of the patch where we
need to properly select type in maybe_fold_comparisons_from_match_pd
function for the created SSA_NAMEs. We can be called for a VECTOR_TYPE
and so that we can't return a boolean_type_node.
+ tree type = TREE_TYPE (op1a);
+ if (TREE_CODE (type) != VECTOR_TYPE)
+ type = boolean_type_node;
Don't you need build_same_sized_truth_vector_type or something, for
instance with AVX512?
Also, IIRC EQ_EXPR for vectors can return either a vector or a boolean. I
don't know if we can end up here with both versions, but if we can,
guessing the type could be dangerous. Would it be hard to add a type
argument to those functions and delegate this to the caller? Any better
idea (maybe this is already safe and I am just missing it)?
--
Marc Glisse