Hi Carl,
On Mon, Sep 23, 2019 at 08:07:32AM -0700, Carl Love wrote:
> * config/rs6000/vsx.md (xxswapd_v4si, xxswapd_v8hi, xxswapd_v16qi):
> New define_insn.
> (vsx_xxpermdi4_le_<mode>, vsx_xxpermdi8_le_V8HI,
> vsx_xxpermdi16_le_V16QI): Removed define_insn.
If you use "<mode>" in a changelog, it usually is handy to say what mode
it is here. Like in this case, (vsx_xxpermdi4_le_<mode> for VSX_W).
> +(define_insn "xxswapd_v16qi"
> + [(set (match_operand:V16QI 0 "vsx_register_operand" "=wa")
> + (vec_select:V16QI
> + (match_operand:V16QI 1 "vsx_register_operand" "wa")
> + (parallel [(const_int 8) (const_int 9)
> + (const_int 10) (const_int 11)
> + (const_int 12) (const_int 13)
> + (const_int 14) (const_int 15)
> + (const_int 0) (const_int 1)
> + (const_int 2) (const_int 3)
> + (const_int 4) (const_int 5)
> + (const_int 6) (const_int 7)])))]
> + "TARGET_VSX"
> +;; AIX does not support the extended mnemonic xxswapd. Use the basic
> +;; mnemonic xxpermdi instead.
> + "xxpermdi %x0,%x1,%x1,2"
> [(set_attr "type" "vecperm")])
Both of the strings ("TARGET_VSX" and "xxpermdi*") should be indented by
only two spacesC, just like the things above and below them are.
> +;; AIX does not support the extended mnemonic xxswapd. Use the basic
> +;; mnemonic xxpermdi instead.
> + "xxpermdi %x0,%x1,%x1,2"
> + [(set_attr "type" "vecperm")])
For the other two, the [(set_attr... as well: only two spaces.
Okay for trunk with that fixed up. Thanks!
Segher
