Jeff pointed out that gcc.target/mips/call-clobbered-4.c started failing after the function-abi series. This is because IRA used to treat partly call-clobbered registers as hard conflicts and so wouldn't consider them for -fcaller-saves. Now that we treat call clobbers the same way regardless of where they come from, we can use $f21 as a caller-save register. This in turn means that -Os is no longer a special case in call-clobbered-3.c.
(The new code is the same size as the old code.) Tested on mipsel-linux-gnu. OK to install? Richard 2019-10-02 Richard Sandiford <richard.sandif...@arm.com> gcc/testsuite/ * gcc.target/mips/call-clobbered-3.c: Remove skip for -Os. * gcc.target/mips/call-clobbered-4.c: Delete. Index: gcc/testsuite/gcc.target/mips/call-clobbered-3.c =================================================================== --- gcc/testsuite/gcc.target/mips/call-clobbered-3.c 2019-03-08 18:14:29.356996347 +0000 +++ gcc/testsuite/gcc.target/mips/call-clobbered-3.c 2019-10-02 12:44:54.644608714 +0100 @@ -1,7 +1,5 @@ /* Check that we handle call-clobbered FPRs correctly. */ /* { dg-skip-if "code quality test" { *-*-* } { "-O0" } { "" } } */ -/* Refer to call-clobbered-4.c to see the expected output from -Os builds. */ -/* { dg-skip-if "uses callee-saved GPR" { *-*-* } { "-Os" } { "" } } */ /* { dg-options "-mabi=32 -modd-spreg -mfpxx -ffixed-f0 -ffixed-f1 -ffixed-f2 -ffixed-f3 -ffixed-f4 -ffixed-f5 -ffixed-f6 -ffixed-f7 -ffixed-f8 -ffixed-f9 -ffixed-f10 -ffixed-f11 -ffixed-f12 -ffixed-f13 -ffixed-f14 -ffixed-f15 -ffixed-f16 -ffixed-f17 -ffixed-f18 -ffixed-f19 -ffixed-f20 -ffixed-f22 -ffixed-f24 -ffixed-f26 -ffixed-f28 -ffixed-f30" } */ void bar (void); Index: gcc/testsuite/gcc.target/mips/call-clobbered-4.c =================================================================== --- gcc/testsuite/gcc.target/mips/call-clobbered-4.c 2019-03-08 18:14:29.356996347 +0000 +++ /dev/null 2019-09-17 11:41:18.176664108 +0100 @@ -1,23 +0,0 @@ -/* Check that we handle call-clobbered FPRs correctly. - This test differs from call-clobbered-3.c because when optimising for size - a callee-saved GPR is used for 'b' to cross the call. */ -/* { dg-skip-if "code quality test" { *-*-* } { "*" } { "-Os" } } */ -/* { dg-options "-mabi=32 -modd-spreg -mfpxx -ffixed-f0 -ffixed-f1 -ffixed-f2 -ffixed-f3 -ffixed-f4 -ffixed-f5 -ffixed-f6 -ffixed-f7 -ffixed-f8 -ffixed-f9 -ffixed-f10 -ffixed-f11 -ffixed-f12 -ffixed-f13 -ffixed-f14 -ffixed-f15 -ffixed-f16 -ffixed-f17 -ffixed-f18 -ffixed-f19 -ffixed-f20 -ffixed-f22 -ffixed-f24 -ffixed-f26 -ffixed-f28 -ffixed-f30" } */ - -void bar (void); -float a; -float -foo () -{ - float b = a + 1.0f; - bar(); - return b; -} -/* { dg-final { scan-assembler-times "lwc1" 4 } } */ -/* { dg-final { scan-assembler-times "swc1" 2 } } */ -/* { dg-final { scan-assembler-times "mtc" 1 } } */ -/* { dg-final { scan-assembler-times "mfc" 1 } } */ -/* { dg-final { scan-assembler-not "mthc" } } */ -/* { dg-final { scan-assembler-not "mfhc" } } */ -/* { dg-final { scan-assembler-not "ldc1" } } */ -/* { dg-final { scan-assembler-not "sdc1" } } */