On Fri, Oct 11, 2019 at 05:54:43PM +0200, Paolo Carlini wrote: > Hi, > > On 11/10/19 17:52, Jakub Jelinek wrote: > > On Fri, Oct 11, 2019 at 05:34:16PM +0200, Paolo Carlini wrote: > > > Hi again... > > > > > > On 11/10/19 17:30, Paolo Carlini wrote: > > > > Oh nice, I wasn't aware of that, to be honest, probably we should audit > > > > the front-end for more such redundant uses. > > > ... and I can confirm that we have *many*. If we agree that removing all > > > of > > > them is the way to go I can do that in a follow up patch. > > If they just guard a pedwarn/warning/warning_at etc., that's fine, if they > > guard also some code that needs to compute something for the diagnostics, > > it might not be redundant.
Yeah, much like with warn_foo guards. > Indeed. We got many of the very straightforward ones ;) Sounds like a nice cleanup! -- Marek Polacek • Red Hat, Inc. • 300 A St, Boston, MA
