On 10/16/19 5:36 PM, JeanHeyd Meneide wrote:
Thanks, Jason! I fixed those last things and I put the changelog below
in the e-mail. I'll figure out how to write a good changelog in a
commit message on the command line soon. :D

In the e-mail like this is fine, thanks.

2019-10-16  JeanHeyd Meneide <phdoftheho...@gmail.com>

gcc/

         * escaped_string.h: New. Refactored out of tree.c to make more
         broadly available (e.g. to parser.c, cvt.c).
         * tree.c: remove escaped_string class

Descriptions should be capitalized and end with a period, e.g. "Remove escaped_string class."

gcc/c-family
         * c-lex.c - update attribute value
gcc/cp/
         * tree.c: Implement p1301 - nodiscard("should have a reason"))
         Added C++2a nodiscard string message handling.
         Increase nodiscard argument handling max_length from 0
         to 1.
         * parser.c: add requirement that nodiscard only be seen
         once in attribute-list
         * cvt.c: add nodiscard message to output, if applicable

These changes all need to mention what definition they are changing, e.g.

* tree.c (handle_nodiscard_attribute): Handle C++2a nodiscard string message.
(std_attribute_table): Increase nodiscard max_length to 1.

Jason

Reply via email to