On Sat, 19 Oct 2019 at 23:45, Richard Sandiford
<richard.sandif...@arm.com> wrote:
>
> Prathamesh Kulkarni <prathamesh.kulka...@linaro.org> writes:
> > Hi Richard,
> > Sorry for not adding the test in PR91532 fix.
> > Is the attached patch OK to commit ?
> >
> > Thanks,
> > Prathamesh
> >
> > 2019-10-18 Prathamesh Kulkarni <prathamesh.kulka...@linaro.org>
> >
> > PR tree-optimization/91532
> > testsuite/
> > * gcc.target/aarch64/sve/fmla_2.c: Add dg-scan check for deleted
> > store.
> >
> > diff --git a/gcc/testsuite/gcc.target/aarch64/sve/fmla_2.c
> > b/gcc/testsuite/gcc.target/aarch64/sve/fmla_2.c
> > index 5c04bcdb3f5..bebb073d1f8 100644
> > --- a/gcc/testsuite/gcc.target/aarch64/sve/fmla_2.c
> > +++ b/gcc/testsuite/gcc.target/aarch64/sve/fmla_2.c
> > @@ -1,4 +1,4 @@
> > -/* { dg-options "-O3" } */
> > +/* { dg-options "-O3 -fdump-tree-ifcvt-details" } */
> >
> > #include <stdint.h>
> >
> > @@ -15,5 +15,6 @@ f (double *restrict a, double *restrict b, double
> > *restrict c,
> > }
> > }
> >
> > +/* { dg-final { scan-tree-dump-times "Deleted dead store" 1 "ifcvt" } } */
> > /* { dg-final { scan-assembler-times {\tfmla\tz[0-9]+\.d, p[0-7]/m,
> > z[0-9]+\.d, z[0-9]+\.d\n} 2 } } */
> > /* { dg-final { scan-assembler-not {\tfmad\t} } } */
>
> I think it'd be better to have a scan-assembler-times for st1d instead,
> so that we're testing the end result rather than how we get there.
Hi Richard,
Thanks for the suggestions, is the attached patch OK ?
Thanks,
Prathamesh
>
> Thanks,
> Richard
2019-10-21 Prathamesh Kulkarni <prathamesh.kulka...@linaro.org>
PR tree-optimization/91532
* gcc.target/aarch64/sve/fmla_2.c: Add dg-scan check for two st1d
insns.
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/fmla_2.c
b/gcc/testsuite/gcc.target/aarch64/sve/fmla_2.c
index 5c04bcdb3f5..51925fa8f50 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/fmla_2.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/fmla_2.c
@@ -17,3 +17,4 @@ f (double *restrict a, double *restrict b, double *restrict c,
/* { dg-final { scan-assembler-times {\tfmla\tz[0-9]+\.d, p[0-7]/m,
z[0-9]+\.d, z[0-9]+\.d\n} 2 } } */
/* { dg-final { scan-assembler-not {\tfmad\t} } } */
+/* { dg-final { scan-assembler-times {\tst1d} 2 } } */
