Sorry for the slow response, still catching up. "Joseph S. Myers" <jos...@codesourcery.com> writes: > This code for doing the increment in from_mode comes from the fix for > PR 37451 and the follow-up fix for PR 37782 > <http://gcc.gnu.org/ml/gcc-patches/2008-09/msg01070.html> > <http://gcc.gnu.org/ml/gcc-patches/2008-10/msg01321.html>. As far as > I can tell the idea of those changes - which were an attempt to > improve optimization - is simply broken when the loop might have > maximum length like this (which in the original PR 37451 case it > can't, but telling that in this code would be nontrivial) - including > the case of nonconstant length as well as that of constant length. > > So this patch reverts both those previous patches and adds testcases > to demonstrate the problem they caused. Bootstrapped with no > regressions on powerpc-linux-gnu. OK to commit?
Yeah, I agree that's the best way out. > (If the patch holds up on trunk I'd propose it for 4.6 and 4.5 branches as > well, as a wrong-code regression fix.) OK for all three unless a release manager objects. Richard
