On Sat, 16 Nov 2019, Iain Sandoe wrote: > Joseph Myers <jos...@codesourcery.com> wrote: > > > This patch adds support for the C2x [[]] attribute syntax to the C > > front end. > > > gcc.dg/gnu2x-attrs-1.c: New tests. > > This test fails on targets without symbol alias support, but it would > be most unfortunate to skip it entirely with the usual dg-requires. > > In this instance, I propose to expect the error for Darwin as per the patch > below, but open to other suggestions, if you prefer something different. > > OK / something else?
This patch is OK. The point of this test is to verify GNU attributes work in C2x syntax, as applied to various constructs, so "alias" is being used as an example of an attribute that applies to declarations but clearly does not make sense on types. It's probably hard to be 100% portable for all such tests. -- Joseph S. Myers jos...@codesourcery.com
