On Mon, Nov 18, 2019 at 1:24 PM Martin Liška <mli...@suse.cz> wrote: > > Hello. > > After my param to option transformation, we lost automatic GGC > detection. It's because init_ggc_heuristics is called before > init_options_struct which memsets all the values to zero first. > > I've tested the patch with --enable-checking=release and I hope > Honza can test it more? > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed?
I prefer to _not_ move all the functions. Moving the init_ggc_heuristics call is OK. Thanks, Richard. > Thanks, > Martin > > gcc/ChangeLog: > > 2019-11-18 Martin Liska <mli...@suse.cz> > > * ggc-common.c (ggc_rlimit_bound): Move to opts.c > (ggc_min_expand_heuristic): Likewise. > (ggc_min_heapsize_heuristic): Likewise. > (init_ggc_heuristics): Likewise. > * ggc.h (init_ggc_heuristics): Remove declaration. > * opts.c (ggc_rlimit_bound): Moved here from ggc-common.c. > (ggc_min_expand_heuristic): Likewise. > (ggc_min_heapsize_heuristic): Likewise. > (init_ggc_heuristics): Likewise. > (init_options_struct): Init GGC params. > * toplev.c (general_init): Remove call to init_ggc_heuristics. > --- > gcc/ggc-common.c | 103 --------------------------------------------- > gcc/ggc.h | 3 -- > gcc/opts.c | 106 +++++++++++++++++++++++++++++++++++++++++++++++ > gcc/toplev.c | 4 -- > 4 files changed, 106 insertions(+), 110 deletions(-) > >
