Hi Jakub,
> On Tue, Nov 05, 2019 at 05:17:10PM +0000, Wilco Dijkstra wrote:
>> Passes bootstrap and regress on AArch64 and x64. OK for commit?
>
> This broke bootstrap on x86_64-linux as well as i686-linux (guess all
> targets that go supports).
indeed: just saw it on Solaris with the native ld.
> The following patch fixes it for me, though not sure which *.c file is best
> and what location in there for the definition.
I've placed it in runtime/go-unwind.c: probestackmaps is defined there
which is declared close to runtime_usestackmaps.
> With this bootstrap succeeded on both x86_64-linux and i686-linux, regtest
> is still pending, but without it it just failed to link libgo.
Same on sparc-sun-solaris2.11 and i386-pc-solaris2.11.
There where quite a number of non-Go regressions all over the place.
Many are like this:
FAIL: gcc.c-torture/execute/complex-6.c -O0 (test for excess errors)
ld: warning: symbol 'err' has differing types:
(file /var/tmp//ccWQCyMc.o type=OBJT; file /lib/libc.so type=FUNC);
/var/tmp//ccWQCyMc.o definition taken
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
