Hi! On Tue, Nov 26, 2019 at 08:33:34PM -0500, Michael Meissner wrote: > This patch changes just the movdi_internal64 insn.
All of the same comments as for the movsi patch. Also: > -;; GPR store GPR load GPR move GPR li GPR lis GPR # > -;; FPR store FPR load FPR move AVX store AVX store AVX > load > -;; AVX load VSX move P9 0 P9 -1 AVX 0/-1 VSX 0 > -;; VSX -1 P9 const AVX const From SPR To SPR > SPR<->SPR > +;; GPR store GPR load GPR move > +;; GPR li GPR lis GPR # > +;; FPR store FPR load FPR move > +;; AVX store AVX store AVX load AVX load VSX move > +;; P9 0 P9 -1 AVX 0/-1 VSX 0 VSX -1 > +;; P9 const AVX const > +;; From SPR To SPR SPR<->SPR > ;; VSX->GPR GPR->VSX > + Please do not add empty lines in the middle of a definition. Also in the movsi patch, if I missed it there. > + "store, load, *, There's a stray tab here (pre-existing, but fix please). > + *, *, *, > + *, *") > + (set_attr "num_insns" > + "*, *, *, > + *, *, 5, Indent is wrong here (second line should have one column more -- or probably the first should have one less. Hard to tell, since it doesn't use tabs to indent (as it should)). Okay for trunk with the changelg and layout fixed. Thanks! Segher
