Hi! So, testing just finished, and indeed:
On 2019-11-27T22:33:25+0000, Joseph Myers <jos...@codesourcery.com> wrote: > On Wed, 27 Nov 2019, Thomas Schwinge wrote: > >> If I turn that conditional cited above into 'if (1)', then nvptx >> offloading testing seems to return to normality, but I have not yet >> assessed whether that has any ill effects on decimal float types support, ... this (see attached) doesn't disturb x86_64-pc-linux-gnu (with nvptx offloading) as well as powerpc64le-unknown-linux-gnu (without offloading) tests in any way. >> and/or how this should be fixed properly. (Julian, please have a look, >> if you can, or tell me if you're busy with other things.) > > Whatever allows this to work for _FloatN types (when x86_64 supports > _Float128 but nxptx doesn't, for example) should be applied to the DFP > types as well. Joseph, Julian, or anyone else, please review if that's (conceptually) the correct fix, and before commit, I'll then remove the 'if' conditional, and re-indent, obviously. If approving this patch (conceptually), please respond with "Reviewed-by: NAME <EMAIL>" so that your effort will be recorded in the commit log, see <https://gcc.gnu.org/wiki/Reviewed-by>. Grüße Thomas
From 272dfd2d0bd05ca32a12a3d30ea2871030e5d784 Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <tschw...@mentor.com>
Date: Thu, 28 Nov 2019 09:17:57 +0100
Subject: [PATCH] WIP Unconditionally enable decimal float types in
'gcc/tree.c:build_common_tree_nodes'
---
gcc/tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/tree.c b/gcc/tree.c
index 5ae250ee595..d61496518fa 100644
--- a/gcc/tree.c
+++ b/gcc/tree.c
@@ -10334,7 +10334,7 @@ build_common_tree_nodes (bool signed_char)
uint64_type_node = make_or_reuse_type (64, 1);
/* Decimal float types. */
- if (targetm.decimal_float_supported_p ())
+ if (1 || targetm.decimal_float_supported_p ())
{
dfloat32_type_node = make_node (REAL_TYPE);
TYPE_PRECISION (dfloat32_type_node) = DECIMAL32_TYPE_SIZE;
--
2.17.1
signature.asc
Description: PGP signature
