On Mon, Nov 25, 2019 at 06:49:49PM -0600, Segher Boessenkool wrote: > On Mon, Nov 25, 2019 at 05:17:08PM -0500, Michael Meissner wrote: > > On Fri, Nov 22, 2019 at 06:20:52PM -0600, Segher Boessenkool wrote: > > > > (define_split > > > > [(set (match_operand:SI 0 "gpc_reg_operand") > > > > (match_operand:SI 1 "const_int_operand"))] > > > > "(unsigned HOST_WIDE_INT) (INTVAL (operands[1]) + 0x8000) >= 0x10000 > > > > - && (INTVAL (operands[1]) & 0xffff) != 0" > > > > + && (INTVAL (operands[1]) & 0xffff) != 0 && !TARGET_PREFIXED_ADDR" > > > > [(set (match_dup 0) > > > > (match_dup 2)) > > > > (set (match_dup 0) > > > > > > Please use num_insns_constant, instead (and fix num_insns_constant_gpr > > > so it knows about SIGNED_34BIT). > > > > The previous patch V6 #1 already had the modification for > > num_insns_constant_gpr. > > It's not in trunk yet?
Sorry, the USA Thanksgiving holiday got in the way. No, the change for num_insns_constant_gpr could not go in until the support for PLI went in (patch V6 #1). So for patches V6 #1-3, I believe you approved #1 (movdi) and #3 (addi3/addsi3) after the changes but not #2 (movsi). I haven't yet applied the specific bits of #1 or #3 after doing the reformating patch. Are the bits for #2 ok with the above change to use num_insns_constant_gpr. Or did you want to see the 3 patches once again after the reformating. -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meiss...@linux.ibm.com, phone: +1 (978) 899-4797
