Sorry. I had to add tm_p.h because Jakub's earlier patch to add output.h to cp-gimplify.c broke AIX.
We certainly can add memmodel.h to cp-gimplify.c. Thanks, David On Thu, Dec 5, 2019 at 8:32 AM Joseph Myers <jos...@codesourcery.com> wrote: > > The change > > 2019-12-04 David Edelsohn <dje....@gmail.com> > > * cp-gimplify.c: Include tm_p.h. > > appears to have broken the build for SPARC. I see > > In file included from ./tm_p.h:4:0, > from > /scratch/jmyers/glibc-bot/src/gcc/gcc/cp/cp-gimplify.c:38: > /scratch/jmyers/glibc-bot/src/gcc/gcc/config/sparc/sparc-protos.h:45:47: > error: use of enum 'memmodel' without previous declaration > extern void sparc_emit_membar_for_model (enum memmodel, int, int); > > with my glibc bot. It's possible this declaration ought to be inside > #ifdef RTX_CODE - that appears to be what other architectures' > <arch>-protos.h files do with all their declarations using enum memmodel. > > https://sourceware.org/ml/libc-testresults/2019-q4/msg00300.html > > -- > Joseph S. Myers > jos...@codesourcery.com