On Sun, 2019-12-08 at 09:43 -0500, David Malcolm wrote: > On Sat, 2019-12-07 at 08:05 -0700, Jeff Law wrote: > > On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > > > This patch adds classes used by the analyzer for handling its > > > diagnostics > > > (queueing them, deduplicating them, precision-of-wording hooks). > > > > > > gcc/ChangeLog: > > > * analyzer/pending-diagnostic.cc: New file. > > > * analyzer/pending-diagnostic.h: New file. > > Definitely want to be using this elsewhere. So again, perhaps move > > out > > of the analyzer into a generic location? > > > > Jeff > > This one I'd prefer to keep in the analyzer subdir, as it actually > uses > some analyzer-specific types, for the precision-of-wording vfuncs; > this > is the interface within the analyzer between the analyzer's > path/event > building logic [1] and the specific descriptions implemented in the > various sm-* files. There may be parts we want to generalize, particularly with the introduction of __bulitin_warning. But if you want to defer making this infrastructure a bit more generic now, I won't strenously object.
jeff >
