On Thu, 2011-12-08 at 15:18 +0100, Jakub Jelinek wrote: > On Thu, Dec 08, 2011 at 03:11:44PM +0100, Richard Guenther wrote: > > >> > Another nit (sorry I didn't see this before :-/) : > > >> > > > >> > > + expr->ops.phi.args = (tree *) xcalloc (nargs, sizeof (tree)); > > >> > > > >> > This leaks, because you missed to add freeing to free_expr_hash_elt. > > >> > Apart from that looks good to me, but I can't approve. > > >> > > > >> > > >> /facered :( > > >> > > >> Thanks. Will fix... > > >> > > >> Bill > > > > > > Richard -- OK with this change? > > > > Yes. > > But please use: > expr->ops.phi.args = XCNEWVEC (tree, nargs); > instead of the above.
Good call. This was copied from another xcalloc call nearby, so I will plan to correct that one as well, as long as I'm in there. Bill > > Jakub >
