On Thu, 2019-12-12 at 10:28 -0500, David Malcolm wrote: > On Wed, 2019-12-11 at 13:04 -0700, Jeff Law wrote: > > On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote:
[...] > > > + > > > +//////////////////////////////////////////////////////////////// > > > // > > > // > > NIT. Is there some reason you don't just use whitespace for these > > kind > > of vertical separators. THe more I see them, the more they bug me, > > probably because that's not been the style we've used for GCC. > > I've been using them to highlight new "chapters" in a source file; > typically there's another comment following them. I'm happy to drop > the one where there isn't a trailing comment, but, I'm hoping there's > an acceptable way to have an "section-header"-style comment. > > We have "^L" in a bunch of places, but my editor (emacs) doesn't do a > great job of highlighting them. > > There's some precedence for: e.g. > > gengtype.c:5094:/******* Manage input files. ******/ > > lto-section-in.c has e.g.: > > /******************************************************************** > *********/ > /* Record renamings of static > declarations */ > /******************************************************************** > *********/ > > tree-vect-loop-manip.c has: > > /******************************************************************** > ***** > Simple Loop Peeling Utilities > > Utilities to support loop peeling for vectorization purposes. > ******************************************************************** > *****/ > > but I suspect given how sporadic these are that this stuff snuck past > review. > > Alternatively I can just drop these and retain the trailing comments, > keeping their formatting. I went ahead and did that, and the result is growing on me; sorry for the noise. Dave