On Fri, 2020-01-10 at 09:46 -0700, Jeff Law wrote: > On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > > The v1 version of this patch was reviewed by Jeff here: > > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00805.html > > TODO: looks like I still need to act on some of his comments there > > > > Changed in v5: > > - update ChangeLog path > > - updated copyright years to include 2020 > > > > Changed in v4: > > - Remove include of gcc-plugin.h, reworking includes accordingly. > > - Wrap everything in #if ENABLE_ANALYZER > > - Remove /// comment lines > > - Add call to make_signal_state_machine: > > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00214.html > > - Rework on_leak vfunc: > > https://gcc.gnu.org/ml/gcc-patches/2019-11/msg02028.html > > - Add DISABLE_COPY_AND_ASSIGN to state_machine > > - Add support for global states and custom transitions: > > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00217.html > > > > This patch adds a "state_machine" base class for describing > > API checkers in terms of state machine transitions. Followup > > patches use this to add specific API checkers. > > > > gcc/analyzer/ChangeLog: > > * sm.cc: New file. > > * sm.h: New file. > So I think my original review comments stand. Once those are > addressed, this is fine for the trunk.
FWIW I sent an updated version of this with those comments addressed as: https://gcc.gnu.org/ml/gcc-patches/2020-01/msg00515.html which sounds approved based on the above. Thanks Dave
