On 1/11/20 1:20 PM, Tamar Christina wrote:
It seems the parameters no longer do anything. i.e. -flto --param ipa-cp-eval-threshold=1 --param ipa-cp-unit-growth=80 doesn't have any effect anymore.
Hi. You are right, the param '--param ipa-cp-unit-growth' is really unused. It's cause by Martin's commit f7725a488382, where we again reinvented renamed param name. It will be fixed with the following obvious commit. I'm going to install it once git will be opened for committing. Martin
>From 72f42e55f3a2cbfd73d142de0b3799b6d787d05f Mon Sep 17 00:00:00 2001 From: Martin Liska <mli...@suse.cz> Date: Mon, 13 Jan 2020 10:00:35 +0100 Subject: [PATCH] Remove usage of legacy param_ipa_cp_unit_growth. gcc/ChangeLog: 2020-01-13 Martin Liska <mli...@suse.cz> * ipa-cp.c (get_max_overall_size): Use newly renamed param param_ipa_cp_unit_growth. * params.opt: Remove legacy param name. --- gcc/ipa-cp.c | 2 +- gcc/params.opt | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/gcc/ipa-cp.c b/gcc/ipa-cp.c index 1c1103ca32b..612f3d0a89b 100644 --- a/gcc/ipa-cp.c +++ b/gcc/ipa-cp.c @@ -3432,7 +3432,7 @@ get_max_overall_size (cgraph_node *node) long large_unit = opt_for_fn (node->decl, param_large_unit_insns); if (max_new_size < large_unit) max_new_size = large_unit; - int unit_growth = opt_for_fn (node->decl, param_ipcp_unit_growth); + int unit_growth = opt_for_fn (node->decl, param_ipa_cp_unit_growth); max_new_size += max_new_size * unit_growth / 100 + 1; return max_new_size; } diff --git a/gcc/params.opt b/gcc/params.opt index a669bbc1aa5..31cc20031b1 100644 --- a/gcc/params.opt +++ b/gcc/params.opt @@ -215,7 +215,7 @@ Common Joined UInteger Var(param_ipa_cp_single_call_penalty) Init(15) IntegerRan Percentage penalty functions containing a single call to another function will receive when they are evaluated for cloning. -param=ipa-cp-unit-growth= -Common Joined UInteger Var(param_ipa_cp_unit_growth) Init(10) Param +Common Joined UInteger Var(param_ipa_cp_unit_growth) Init(10) Param Optimization How much can given compilation unit grow because of the interprocedural constant propagation (in percent). -param=ipa-cp-value-list-size= @@ -246,10 +246,6 @@ Maximum pieces that IPA-SRA tracks per formal parameter, as a consequence, also Common Joined UInteger Var(param_ipa_sra_ptr_growth_factor) Init(2) Param Optimization Maximum allowed growth of number and total size of new parameters that ipa-sra replaces a pointer to an aggregate with. --param=ipcp-unit-growth= -Common Joined UInteger Var(param_ipcp_unit_growth) Optimization Init(10) Param -How much can given compilation unit grow because of the interprocedural constant propagation (in percent). - -param=ira-loop-reserved-regs= Common Joined UInteger Var(param_ira_loop_reserved_regs) Init(2) Param Optimization The number of registers in each class kept unused by loop invariant motion. -- 2.24.1