On Tue, 2020-01-21 at 15:00 -0700, Sandra Loosemore wrote: > In doing some nios2-elf testing, I ran into a bunch of failures in > constexpr-related tests in the C++ testsuite. This target defaults to > -fno-delete-null-pointer-checks at the request of Altera/Intel, in order > to support some of their BSPs where 0 is a legitimate memory address. > Some other bare-metal targets also default to > -fno-delete-null-pointer-checks. > > This patch makes the dependence of these tests on > -fdelete-null-pointer-checks explicit. I've previously fixed some other > tests that failed on nios2-elf in the same way so this is borderline > obvious, but it's a little troubling to me that the correct semantics of > some of these testcases seems to depend on what we document in the > manual as an optimization option. :-S Maybe there is some other bug here? > > Anyway, if nobody has any objections or better ideas, I will go ahead > and commit this in a few days. It'd be nice to know why that flag matters for constexpr. But I've got no problem with the change itself.
jeff