On 2/3/20 3:08 PM, Segher Boessenkool wrote: > On Sun, Feb 02, 2020 at 08:00:44AM +0000, Bernd Edlinger wrote: >>>> Okay, thanks. That is a strong indication that there is no need >>>> to interfere with screen, which proves that any auto-disabling should >>>> have a very specific terminal detection logic. >>> >>> Jakub says that he tested with a recent gnome-terminal. That works, of >>> course. Mnay other terminals will not, and switching what terminal is >>> attached to your screen session will not work well either, as far as I >>> can tell. >> >> I understood his statement, that the URLs are stripped from the data >> stream by screen and are no longer visible, even if the terminal would >> support them i.e. you connect from a gnome-terminal. > > It looks like tmux strips it as well. But in my earlier testing it did > not? Confused. Maybe this was the auto-detect thing, dunno. I guess > I'll test with more tmux versions when I find some more time for this. >
Okay, I see, I will remove the tmux detection until further notice. >> But work fine when the compiler runs natively in a gnome-terminal. > > It is big garbage for me, both with bell (which is much worse on some > other terminals), and with the string terminator escape (ESC \). > So gnome terminal is a problem, since it depend heavily on the software version, VTE library, and gnome-terminal. Sometimes URLs are functional, sometimes competely buggy. But, wait a moment, here is the deal: I can detect old gnome terminals, they have COLORTERM=gnome-terminal (and produce garbage) but new gnome terminal with true URL-support have COLORTERM=truecolor So how about adding that to the detection logic ? Jakub, can you confirm that the COLORTERM on your working gnome-terminal is set to "truecolor" ? Obviously, my top priority is not breaking URLs on that working gnome version. Thanks Bernd.
