On Mon, Feb 03, 2020 at 06:19:07PM -0500, Michael Meissner wrote: > On Fri, Jan 31, 2020 at 05:43:20PM -0600, Segher Boessenkool wrote: > > On Thu, Jan 09, 2020 at 07:27:58PM -0500, Michael Meissner wrote: > > > * config/rs6000/rs6000.c (reg_to_non_prefixed): Add forward > > > reference. > > > > FWIW, it is better to just reorder the code, in most cases. > > > > > (hard_reg_and_mode_to_addr_mask): Delete, no longer used. > > > > Just "Delete.". Changelogs say what, not why; you have the commit > > message for that. > > > > > + new_addr = gen_rtx_PLUS (Pmode, op0, offset_rtx); > > > > So this depends on op0 not being r0 here. Do we guarantee that somehow? > > It isn't obvious, so add an assert for this please? (Or do I miss > > something obvious? :-) ) > > That particular code is inside if CONST_INT_P (op1). Therefore, op0 cannot be > r0, but I can add an assertion.
Please do (unless you think I'm just totally silly for not seeing this -- it's not always as obvious in a patch as it will be in the final code). Segher
