On 2/6/20 2:26 PM, Jan Hubicka wrote:
Hi.

The patch reverts mangling of filenames due to file
length limitation. Creation of a folder tree seems fine
in context of PGO.

Ready for master?
Thanks,
Martin

gcc/ChangeLog:

2020-02-06  Martin Liska  <mli...@suse.cz>

        PR gcov-profile/91971
        PR gcov-profile/93466
        * coverage.c (coverage_init): Revert mangling of
        path into filename.  It can lead to huge filename length.
        Creation of subfolders seem more natural.

This does make sense to me - the overly long filenames looked like a bad
move to me.  But what was motivation for introducing them at first
place?

The motivation is described here:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91971#c0

Well, the original issue is not a fundamental problem.
I'm going to install the patch.

Martin


Patch is OK unless that reason was very good :)

Honza


Reply via email to