On Thu, 2020-02-13 at 17:23 -0600, Segher Boessenkool wrote: > On Thu, Feb 13, 2020 at 04:41:09PM -0600, will schmidt wrote: > > Attempting to clean up some more testcase failures. > > This test in particular exercises the -ftree-vectorize > > option, and by inspection I see this fails out with assorted > > "conversion not supported by target" messages on power7 and > > earlier systems. > > > > Thus, this would limits the scan-dump check of "LOOP VECTORIZED" to > > those targets supporting power8 vector support. > > The testcase itself otherwise runs fine, so limiting the test > > itself seems unnecessary. > > -/* { dg-final { scan-tree-dump-times "LOOP VECTORIZED" 14 "vect" } > > } */ > > +/* { dg-final { scan-tree-dump-times "LOOP VECTORIZED" 14 "vect" { > > target p8vector_hw } } } */ > > That actually checks if the hardware is p8 or later, while what you > care > about is what options are compiled with. Say, if running on a p8 but > compiling for a p7 this will fail?
Right... I did some experimentation and havn't come up with anything I'm completely satisfied with. The powerpc_p8vector_ok check doesn't fail out like I'd expect it to on a power7 target. Ok, so it appears check_effective_target_powerpc_p8vector_ok () inserts a "-mpower8-vector" option as part of it's test, so as long as the compiler on a power7 system is able to generate power8 code, that power8-vector check will pass, even if we have not otherwise indicated power8 in our test incantation. I'll think on this one some more... thanks -Will > > > Segher