On 1/30/20 5:13 PM, Jan Hubicka wrote:
@@ -330,7 +334,7 @@
stream_out_histogram_value (struct output_block *ob, histogram_value hist)
/* When user uses an unsigned type with a big value, constant converted
to gcov_type (a signed type) can be negative. */
gcov_type value = hist->hvalue.counters[i];
- if (hist->type == HIST_TYPE_TOPN_VALUES && i > 0)
+ if (hist->type == HIST_TYPE_TOPN_VALUES)
;
else
gcc_assert (value >= 0);
I forgot to include this obvious hunk in my installed patch and
I noticed that during LTO PGO bootstrap.
Let's fix it.
Martin
>From 5c72754ab734d9b43db19d51ce196d582d85002c Mon Sep 17 00:00:00 2001
From: Martin Liska <mli...@suse.cz>
Date: Tue, 18 Feb 2020 16:18:32 +0100
Subject: [PATCH] Restore LTO PGO bootstrap after ea0b12523d0d9a9059b5.
gcc/ChangeLog:
2020-02-18 Martin Liska <mli...@suse.cz>
* value-prof.c (stream_out_histogram_value): Restore LTO PGO
bootstrap by missing removal of invalid sanity check.
---
gcc/value-prof.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/value-prof.c b/gcc/value-prof.c
index 5f940f40399..8e9f129708a 100644
--- a/gcc/value-prof.c
+++ b/gcc/value-prof.c
@@ -332,7 +332,7 @@ stream_out_histogram_value (struct output_block *ob, histogram_value hist)
/* When user uses an unsigned type with a big value, constant converted
to gcov_type (a signed type) can be negative. */
gcov_type value = hist->hvalue.counters[i];
- if (hist->type == HIST_TYPE_TOPN_VALUES && i > 0)
+ if (hist->type == HIST_TYPE_TOPN_VALUES)
;
else
gcc_assert (value >= 0);
--
2.25.0
