On 2/25/20 4:00 PM, Segher Boessenkool wrote:
On Mon, Feb 24, 2020 at 03:20:30PM -0600, Bill Schmidt wrote:
These two test cases have assembly code that requires a valid TOC.
Make sure that we don't use the PC-relative ABI extensions that
violate this requirement.
Tested and verified on powerpc64le-unknown-linux-gnu. Is this
okay for trunk?
Okay, thanks!
Should there be a testsuite/gcc.target/powerpc/ppc64-abi-pcrel.c as well?
I don't think we need anything to replace these particular tests. They
are testing correct parameter passing, and we have exhaustive testing
for those aspects in the ABI compatibility testsuite (and they don't
change for PC-relative). We also have a number of tests that were
added specifically for the TOC-removal aspects of PC-relative addressing
when those pieces went in. It's of course always true that more tests
are better, but I don't think we're losing coverage with this patch.
Thanks,
Bill
Segher
