Hi Paul, Thanks for the review. This is now committed as:
r10-6976-gf3c276aec26d9e406cc4bbf0e18b1105df63f0ee I'll keep this in mind for future patches - this one seemed simple enough that I'd be confident to commit it without review after waiting for a few days. I'm hoping to find time to finish some other patches soon, some of which are more complicated and I'd definitely want to get reviewed before I commit them. Thanks again everyone. -Andrew On Monday, March 2, 2020 6:41:46 AM PST Paul Richard Thomas wrote: > Andrew, > > I agree with Steve. That said, I took a look at your patch and it's > just fine. OK to commit. > > Cheers > > Paul > > On Mon, 2 Mar 2020 at 02:10, Steve Kargl > > <s...@troutmask.apl.washington.edu> wrote: > > On Sun, Mar 01, 2020 at 11:43:23PM +0100, Thomas Koenig wrote: > > > Am 01.03.20 um 23:42 schrieb Steve Kargl: > > > > PS: in general, after multiple > > > > pings, just commit the patch. > > > > > > ... well, maybe after a "If there is no reply within a > > > couple of days, I will commit this" :-) > > > > Andrew submitted the patch and pinged it twice. gfortran > > development is running on fumes. Beating one's head > > against a wall seems counter productive. I'm operating > > on a principle that if one has commit access for gfortran, > > one is committing a patch with the best attentions. Could > > this lead to a regression? Sure. The alternative of > > constantly pinging patches is to simply stop submitting > > patches. > > > > > > -- > > Steve -- * Andrew Benson: http://users.obs.carnegiescience.edu/abenson/contact.html * Galacticus: https://github.com/galacticusorg/galacticus
