Hi!
On Mon, Mar 02, 2020 at 04:01:11PM -0600, Bill Schmidt wrote:
> PR87560 reports an ICE when a test case is compiled with -mpower9-vector
> and -mno-altivec. This patch terminates compilation with an error when
> this combination (and other unreasonable ones) are requested.
(If this is your commit message: there are a lot of stray tabs in it).
> Bootstrapped and tested on powerpc64le-unknown-linux-gnu with no
> regressions. Reported error is now:
>
> f951: Error: '-mno-altivec' turns off '-mpower9-vector'
I'm not happy at all with this mechanism, it is yet another place we
put this same info down. It should be possible to just handle this in
rs6000.opt . But, this patch just adds an extra entry.
> Is this okay for master, and for backport to releases/gcc-9 after the
> 9.3 release? There's no urgency in getting this in 9.3.
Okay for both. Thanks!
One thing: please add a PR tag to the changelog:
> 2020-03-02 Bill Schmidt <wschm...@linux.ibm.com>
PR target/87560
> * rs6000-cpus.def (OTHER_ALTIVEC_MASKS): New #define.
> * rs6000.c (rs6000_disable_incompatible_switches): Add table entry
> for OPTION_MASK_ALTIVEC.
(and indent the rest with tabs as well?)
Segher
