On Thu, Mar 5, 2020 at 10:18 PM Iain Sandoe <i...@sandoe.co.uk> wrote: > > Hello JunMa, > > JunMa <ju...@linux.alibaba.com> wrote: > > > Ping > > Once again, sorry for taking time to review this. > > > 在 2020/2/27 上午10:18, JunMa 写道: > >> 在 2020/2/11 上午10:14, JunMa 写道: > >> Kindly ping > >> > >> Regards > >> JunMa > >>> Hi > >>> In maybe_promote_captured_temps, the cleanup_point_stmt has been > >>> stripped when handle temporaries captured by reference. However, maybe > >>> there are non-reference temporaries in current stmt which cause ice in > >>> gimpilify pass. > >>> > >>> This patch fix this. The testcase comes from cppcoro and is reduced by > >>> creduce. > > With current trunk + Bin’s two approved patches. > > I see no change in the testcase (lambda-09-capture-object.C) before / after > the patch > (it fails for me at -O0 only - in both cases).
Hi Iain, I tried exactly what you did, however, the result is different. With current trunk(cb2c60206f4f2218f84ccde21663b00de068d8c7) with my approved patch, the case(lambda-09-capture-object.C) still causes ICE. Actually, the same ICE happens in testcase(co-await-syntax-11.C) added by my patch. So this one is a prerequisite for my approved patch. Thanks, bin > > please could you check? > thanks > Iain >
