Hi Dennis, > -----Original Message----- > From: Dennis Zhang <dennis.zh...@arm.com> > Sent: 19 March 2020 14:03 > To: Kyrylo Tkachov <kyrylo.tkac...@arm.com>; gcc-patches@gcc.gnu.org > Cc: nd <n...@arm.com>; Richard Earnshaw <richard.earns...@arm.com>; > Ramana Radhakrishnan <ramana.radhakrish...@arm.com> > Subject: Re: [PATCH][Arm][1/3] Support for Arm Custom Datapath Extension > (CDE): enable the feature > > Hi Kyrylo, > > >________________________________________ > >From: Kyrylo Tkachov <kyrylo.tkac...@arm.com> > >Sent: Wednesday, March 18, 2020 9:04 AM > >To: Dennis Zhang; gcc-patches@gcc.gnu.org > >Cc: nd; Richard Earnshaw; Ramana Radhakrishnan > >Subject: RE: [PATCH][Arm][1/3] Support for Arm Custom Datapath > >Extension (CDE): enable the feature > > > >Hi Dennis, > > > >> -----Original Message----- > >> From: Dennis Zhang <dennis.zh...@arm.com> > >> Sent: 12 March 2020 12:06 > >> To: gcc-patches@gcc.gnu.org > >> Cc: nd <n...@arm.com>; Richard Earnshaw <richard.earns...@arm.com>; > >> Ramana Radhakrishnan <ramana.radhakrish...@arm.com>; Kyrylo > Tkachov > >> <kyrylo.tkac...@arm.com> > >> Subject: [PATCH][Arm][1/3] Support for Arm Custom Datapath Extension > >> (CDE): enable the feature > >> > >> Hi all, > >> > >> This patch is part of a series that adds support for the ARMv8.m > >> Custom Datapath Extension. > >> This patch defines the options cdecp0-cdecp7 for CLI to enable the > >> CDE on corresponding coprocessor 0-7. > >> It also adds new check-effective for CDE feature. > >> > >> ISA has been announced at > >> https://developer.arm.com/architectures/instruction-sets/custom- > >> instructions > >> > >> Regtested and bootstrapped. > >> > >> Is it OK to commit please? > > > >Can you please rebase this patch on top of the recent MVE commits? > >It currently doesn't apply cleanly to trunk. > >Thanks, > >Kyrill > > The rebase patches is as attached. > Is it OK to commit?
Ok, with a few fixes... diff --git a/gcc/testsuite/gcc.target/arm/pragma_cde.c b/gcc/testsuite/gcc.target/arm/pragma_cde.c new file mode 100644 index 00000000000..97643a08405 --- /dev/null +++ b/gcc/testsuite/gcc.target/arm/pragma_cde.c @@ -0,0 +1,98 @@ +/* Test for CDE #prama target macros. */ +/* { dg-do compile } */ Typo in "pragma" in the comment. +# A series of routines are created to 1) check if a given architecture is +# effective (check_effective_target_*_ok) and then 2) give the corresponding +# flags that enable the architecture (add_options_for_*). +# The series includes: +# arm_v8m_main_cde: Armv8-m CDE (Custom Datapath Extension). +# arm_v8m_main_cde_fp: Armv8-m CDE with FP registers. +# arm_v8_1m_main_cde_mve: Armv8.1-m CDE with MVE. +# Usage: +# /* { dg-require-effective-target arm_v8m_main_cde_ok } */ +# /* { dg-add-options arm_v8m_main_cde } */ +# The tests are valid for Arm. + +foreach { armfunc armflag armdef } { New effective target checks need to be documented in doc/invoke.texi Ok with those changes. Kyrill > > Thanks > Dennis