On Tue, 2020-03-31 at 08:11 -0700, H.J. Lu via Gcc-patches wrote:
> Since constant_call_address_operand has
>
> ;; Test for a pc-relative call operand
> (define_predicate "constant_call_address_operand"
> (match_code "symbol_ref")
> {
> if (ix86_cmodel == CM_LARGE || ix86_cmodel == CM_LARGE_PIC
> || flag_force_indirect_call)
> return false;
> if (TARGET_DLLIMPORT_DECL_ATTRIBUTES && SYMBOL_REF_DLLIMPORT_P (op))
> return false;
> return true;
> })
>
> even if cgraph_node::get (cfun->decl)->only_called_directly_p () returns
> false, the fuction may still be called indirectly. Copy the logic from
> constant_call_address_operand to rest_of_insert_endbranch to insert ENDBR
> at function entry if function will be called indirectly.
>
> gcc/
>
> PR target/94417
> * config/i386/i386-features.c (rest_of_insert_endbranch): Insert
> ENDBR at function entry if function will be called indirectly.
Can you just call constant_call_address_operand rather than copying its
contents?
jeff
>
