Re: [PATCH]aarch64: falkor-tag-collision-avoidance.c fix valid_src_p for use of uninitialized value

[Andrea Corallo]

Kyrylo Tkachov <kyrylo.tkac...@arm.com> writes:

> -  if (!REG_P (addr.base))
> +  if (addr.type == ADDRESS_SYMBOLIC || !REG_P (addr.base))
>      return false;
>
> Hmm, given that the code below only handles the  ADDRESS_REG_* forms, how 
> about we get defensive here and check that addr.type is not one of 
> ADDRESS_REG_* instead?
> That way, if aarch64_classify_address is extended in the future with new 
> addr.type values that leave addr.base in the wrong forms, this code will not 
> need to be updated.

Yeah make sense.

Thanks

  Andrea