On 4/16/20 5:21 PM, Segher Boessenkool wrote:
>> +#undef TARGET_CANNOT_SUBSTITUTE_MEM_EQUIV_P
>> +#define TARGET_CANNOT_SUBSTITUTE_MEM_EQUIV_P
>> rs6000_cannot_substitute_mem_equiv_p
>
> This line gets too long, you could split it in two?
Done.
>> +/* { dg-do compile { target { powerpc*-*-linux* } } } */
>> +/* { dg-require-effective-target powerpc_p8vector_ok } */
>> +/* { dg-options "-mdejagnu-cpu=power8 -O3 -fstack-protector-strong" } */
>
> Is there a reason to do this on Linux only? If not, you can just do
> { dg-do compile } ?
Ok, changed. I was trying to limit it to POWER and then thought that
no other OS on POWER supports P8 vector, so I added that hunk, but I
guess the dg-requires-effective-target is enough.
> Okay for trunk, however you choose to resolve those things. Thank you!
Thanks for the review. I just pushed the updated patch.
Peter
