This appears to be a copy&paste error, which cppcheck diagnoses. PR other/94629 * include/debug/formatter.h (_Error_formatter::_Parameter): Fix redundant assignment in constructor.
Tested powerpc64le-linux, committed to master.
commit a2c0fa35d0dc8912b0c1a658234221de61e60840 Author: Jonathan Wakely <jwak...@redhat.com> Date: Sun Apr 19 20:54:38 2020 +0100 libstdc++: Fix redundant assignment (PR 94629) This appears to be a copy&paste error, which cppcheck diagnoses. PR other/94629 * include/debug/formatter.h (_Error_formatter::_Parameter): Fix redundant assignment in constructor. diff --git a/libstdc++-v3/include/debug/formatter.h b/libstdc++-v3/include/debug/formatter.h index 998f8056601..bb9b3e5653a 100644 --- a/libstdc++-v3/include/debug/formatter.h +++ b/libstdc++-v3/include/debug/formatter.h @@ -299,7 +299,6 @@ namespace __gnu_debug _M_variant._M_iterator._M_name = __name; _M_variant._M_iterator._M_address = std::__addressof(__it); _M_variant._M_iterator._M_type = _GLIBCXX_TYPEID(_Iterator); - _M_variant._M_iterator._M_constness = _M_variant._M_iterator._M_constness = __it._S_constant() ? __const_iterator : __mutable_iterator; _M_variant._M_iterator._M_sequence = __it._M_get_sequence();