Hi, > -----Original Message----- > From: Richard Sandiford [mailto:richard.sandif...@arm.com] > Sent: Monday, May 11, 2020 10:27 PM > To: Yangfei (Felix) <felix.y...@huawei.com> > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH PR94991] aarch64: ICE: Segmentation fault with option - > mgeneral-regs-only > > LGTM. Pushed with one minor formatting fix: > > > @@ -1364,7 +1364,11 @@ > > if (!TARGET_FLOAT) > > { > > aarch64_err_no_fpadvsimd (<MODE>mode); > > - FAIL; > > + machine_mode intmode > > + = int_mode_for_size (GET_MODE_BITSIZE (<MODE>mode), > 0).require (); > > The "=" should only be indented by two spaces relative to the first line.
Thanks for fixing the bad formatting :- ) I was expecting issues like that to be reported by contrib/check_GNU_style.sh. Will be more carefull. Felix