On 5/11/20 7:16 AM, Segher Boessenkool wrote:
Hi!
On Sat, May 09, 2020 at 08:08:34PM -0500, Bill Schmidt wrote:
I should have noticed this patch before submitting Kelvin's earlier
related patches, sorry. I think it should still be fine to apply
the patches in order, but if you'd like me to combine this into the
two earlier ones, I'd be happy to do that.
The intermediary step works just fine as well, so it is fine as-is.
One thing:
* config/rs6000/rs6000-c.c (altivec_resolve_overloaded_builtin):
Change fourth operand for vec_ternarylogic to require
compatibility with unsigned SImode rather than unsigned QImode.
Is it still checked for range 0..255 though? (If the compiler can
derive that).
Yep, we already have this:
if (icode == CODE_FOR_xxeval)
{
/* Only allow 8-bit unsigned literals. */
STRIP_NOPS (arg3);
if (TREE_CODE (arg3) != INTEGER_CST
|| TREE_INT_CST_LOW (arg3) & ~0xff)
{
error ("argument 4 must be an 8-bit unsigned literal");
return CONST0_RTX (tmode);
}
}
Thanks for the review!
Bill
In either case, if that is what the ABI says, that is what the ABI says,
so okay for trunk.
Thanks!
Segher
