On Fri, 2020-05-15 at 13:20 +0200, Martin Liška wrote: > On 5/15/20 12:58 PM, David Malcolm wrote: > > On Fri, 2020-05-15 at 10:59 +0200, Martin Liška wrote: > > > Hi. > > > > > > Since we moved to git world and we're in the preparation for > > > ChangeLog messages > > > being in git commit messages, I think it's the right time to also > > > simplify mklog > > > script. > > > > > > I'm sending a new version (which should eventually replace > > > contrib/mklog and contrib/mklog.pl). > > > Changes made in the version: > > > > > > - the script uses unifdiff - it rapidly simplifies parsing of the > > > '+- > > > !' lines that is done > > > in contrib/mklog > > > - no author nor date stamp is used - that all can be get from git > > > - --inline option is not supported - I don't see a use-case for > > > it > > > now > > > - the new script has a unit tests (just few of them for now) > > > > > > I compares results in between the old Python script for last 80 > > > commits and it's very close, > > > in some cases it does even better. > > > > > > I'm planning to maintain and improve the script for the future. > > > > > > Thoughts? > > > Martin > > > +class TestMklog(unittest.TestCase): > > > + def test_macro_definition(self): > > > + changelog = generate_changelog(PATCH1) > > > + assert changelog == EXPECTED1 > > > + > > > + def test_changed_argument(self): > > > + changelog = generate_changelog(PATCH2) > > > + assert changelog == EXPECTED2 > > > + > > > + def test_enum_and_struct(self): > > > + changelog = generate_changelog(PATCH3) > > > + assert changelog == EXPECTED3 > > > + > > > + def test_no_function(self): > > > + changelog = generate_changelog(PATCH3, True) > > > + assert changelog == EXPECTED3B > > Thank you David for review. > > However I see the same output for both operator== and assertEqual. > Probably > because of usage of pytest version 4?
Ah, yes. pytest does "magical" things with frame inspection IIRC to scrape the locals out of the failing python stack frame. Dave
