Hi Martin > -----Original Message----- > From: Martin Liška <mli...@suse.cz> > Sent: 21 May 2020 16:01 > To: gcc-patches@gcc.gnu.org > Cc: Sudakshina Das <sudi....@arm.com> > Subject: [PATCH] Fix handling of OPT_mgeneral_regs_only in attribute. > > Hi. > > Similarly to: > > case OPT_mstrict_align: > if (val) > opts->x_target_flags |= MASK_STRICT_ALIGN; > else > opts->x_target_flags &= ~MASK_STRICT_ALIGN; > return true; > > the MASK_GENERAL_REGS_ONLY mask should be handled the same way.
My old patch added the -mno-* version of the option and hence needed the change. Without the _no_ version for mgeneral-regs-only, I would imagine "val" to only ever have 1 as a value. Am I missing something here? Sudi > > @Sudakshina: The 'opts->x_target_flags |= MASK_STRICT_ALIGN' change is > not backported to all active branches. Can you please do it? > > Ready to be installed? > > gcc/ChangeLog: > > 2020-05-21 Martin Liska <mli...@suse.cz> > > * common/config/aarch64/aarch64-common.c > (aarch64_handle_option): > Properly maask MASK_GENERAL_REGS_ONLY based on val. > --- > gcc/common/config/aarch64/aarch64-common.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >
