On 5/28/20 1:20 PM, Jakub Jelinek wrote:
On Thu, May 28, 2020 at 11:09:41AM +0200, Martin Liška wrote:
On 5/28/20 11:05 AM, Pierre-Marie de Rodat wrote:
Thanks! The updated patch is attached.

The patch is fine, please install it.

I'd like to mention that for file renames, perhaps it is acceptable not to
have a ChangeLog entry for pure file rename (do we require it after
Pierre-Marie's patch), but if it is rename + some changes, the committer
should still describe the changes in there, which is something the script
can't do for him.

That will likely depend on the similarity level (100%). But I'm not sure 
GitPython
can provide such an information. It seems to me a nit, file renaming is quite 
rare
operation.

Martin


        Jakub


Reply via email to