On Mon, 2020-05-18 at 20:11 +0200, Aldy Hernandez wrote: > As a follow-up to the patch moving array bounds checking into its own > class, this moves the class into its own files. As I've mentioned > previously, having it in tree-vrp just pollutes the file with unrelated > stuff. > > Jeff, I know you've mentioned you'd like to move the array bounds > checking to the path isolation pass at some point. Would the current > approach work for you? I'm ok, inasmuch as it's gone from tree-vrp.c, > the file is bloated enough as it is. Yes, this is fine. There's nothing conceptually about the array bounds checking that requires it to live in VRP -- it was a historical decision because access to the IL after ASSERT_EXPR insertion gave better results.
As you probably remember, it was your investigative work on moving the array bounds bits out of VRP with an eye towards isolating them and turning them into trap that was a significant factor in kicking off the Ranger project years ago. This might need minor edits to make sure you don't lose Martin's work from May 18 in check_mem_ref(). Jeff
