On 6/1/20 7:24 PM, Jonathan Wakely wrote:
On Mon, 25 May 2020 at 23:50, Jakub Jelinek via Gcc <g...@gcc.gnu.org> wrote:
Hi!
I've turned the strict mode of Martin Liška's hook changes,
which means that from now on no commits to the trunk or release branches
should be changing any ChangeLog files together with the other files,
ChangeLog entry should be solely in the commit message.
The DATESTAMP bumping script will be updating the ChangeLog files for you.
If somebody makes a mistake in that, please wait 24 hours (at least until
after 00:16 UTC after your commit) so that the script will create the
ChangeLog entries, and afterwards it can be fixed by adjusting the ChangeLog
files. But you can only touch the ChangeLog files in that case (and
shouldn't write a ChangeLog entry for that in the commit message).
If anything goes wrong, please let me, other RMs and Martin Liška know.
The libstdc++ manual is written in Docbook XML, but we commit both the
XML and generated HTML pages to Git. Sometimes a small XML file can
result in dozens of mechanical changes to the generated HTML files,
which we record in the ChangeLog as:
* doc/html/*: Regenerated.
With the new checks we need to name every generated file individually.
If we add that directory to the ignored_prefixes list, we won't need
to name them. But then the doc/html/* entry will give an error, and
changes to the HTML files can be committed without any ChangeLog
entry. Should we just stop mentioning the HTML in the ChangeLog?
We could do something like the attached patch, but it seems overkill
for this one special case.
The patch is fine to me.
Can you please a pytest for the situation: contrib/gcc-changelog/test_email.py ?
Martin
